Skip to content

fix: harden browser page webkit compatibility#133

Merged
cxymds merged 1 commit into
mainfrom
codex/harden-browser-webkit-browser-page
Jun 14, 2026
Merged

fix: harden browser page webkit compatibility#133
cxymds merged 1 commit into
mainfrom
codex/harden-browser-webkit-browser-page

Conversation

@cxymds

@cxymds cxymds commented Jun 14, 2026

Copy link
Copy Markdown
Member

Pull Request

Description

Harden the browser bucket/object pages against WebKit-sensitive runtime behavior by normalizing date values from S3 responses, guarding object-list fetch rendering, and replacing direct queueMicrotask usage with a compatibility helper.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Testing

  • Unit tests added/updated
  • Manual testing completed
node --test tests/lib/browser-safety-source.test.js tests/lib/object-list-source.test.js
./node_modules/.bin/eslint app/'(dashboard)'/browser/page.tsx components/buckets/list.tsx components/events/new-form.tsx components/object/info.tsx components/object/list.tsx components/object/view.tsx contexts/api-context.tsx contexts/s3-context.tsx lib/safe-date.ts lib/schedule-microtask.ts tests/lib/browser-safety-source.test.js tests/lib/object-list-source.test.js
./node_modules/.bin/prettier --check app/'(dashboard)'/browser/page.tsx components/buckets/list.tsx components/events/new-form.tsx components/object/info.tsx components/object/list.tsx components/object/view.tsx contexts/api-context.tsx contexts/s3-context.tsx lib/safe-date.ts lib/schedule-microtask.ts tests/lib/browser-safety-source.test.js tests/lib/object-list-source.test.js

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing tests pass
  • No new dependencies added, or they are justified

Related Issues

Closes #129

Screenshots (if applicable)

Additional Notes

This PR intentionally excludes the preview modal fullscreen fix so the broader browser-page hardening changes can be reviewed separately.

@cxymds cxymds merged commit 3977d67 into main Jun 14, 2026
10 checks passed
@cxymds cxymds deleted the codex/harden-browser-webkit-browser-page branch June 14, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Console crashes ("This page couldn't load") on iOS Safari/WebKit when clicking a bucket; works on desktop Chrome

1 participant